feat(trials): freeze failure taxonomy, regrade path, and exit codes - #457
Merged
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Settle #435 with measurement_failures in summary, failure_reason on cells, three-valued process exit, grader_result exit_code removal, regrade command, and export privacy projection. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
solomonneas
force-pushed
the
feat/trial-failure-taxonomy
branch
from
July 23, 2026 14:10
06c8eed to
194a13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/model-trial-taxonomy.md(Settle the trial failure taxonomy, retry policy, and regrade path before the stable cut #435).failure_reasonon cells (timeout,transport_drop,provider_5xx), dropexit_codefromgrader_result.v1, and splitmeasurement_failures/partial_scoresinsummary.json.brigade model trial regrade, resume regrade forgrader_error, andproject_cellexport privacy.Closes #435.
Test plan
brigade work verify run --target . --command "pytest -q tests/ -k 'trial or model_trials or grader or eval'" --capture brigade-work./scripts/verify(3944 passed, 82.49% coverage)failure_reason,process_exitdominance,project_cellprivacy, partial score splitNotes
--retry-transientintentionally deferred per Settle the trial failure taxonomy, retry policy, and regrade path before the stable cut #435.Made with Cursor