Skip to content

test(harness): probe live discovery in isolated sandboxes - #459

Merged
solomonneas merged 2 commits into
mainfrom
codex/issue-345-live-discovery
Jul 23, 2026
Merged

test(harness): probe live discovery in isolated sandboxes#459
solomonneas merged 2 commits into
mainfrom
codex/issue-345-live-discovery

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • Add --run-deep-probes as an explicit opt-in while preserving the default declared_only_not_executed policy.
  • Extend deep-probe fixtures with optional inline {command, args} discovery specs and emit one receipt per declared probe.
  • Run specified probes in throwaway HOME/XDG sandboxes with exact command and argument gates, bounded output, path scrubbing, and credential redaction.
  • Keep spec-less, blocked, external-only, and invalid fixtures declared-only without process launch.

Verification

  • brigade work verify run --target . --command "pytest -q tests/test_harness_conformance_probe.py" --capture brigade-work
    • Receipt 20260723-152256-work-verify-1d1010
    • 54 passed in 0.41s
  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
    • Receipt 20260723-152316-work-verify-7abfb7
    • 4014 passed, 3 skipped in 379.31s
    • Coverage: 82.53%

Closes #345.

Co-Authored-By: Cursor <cursoragent@cursor.com>

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f64a1cc-ca08-487c-af1d-389da49597e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-345-live-discovery

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 23, 2026
Co-authored-by: Codex <codex@openai.com>
@solomonneas
solomonneas merged commit 33ee8f9 into main Jul 23, 2026
28 checks passed
@solomonneas
solomonneas deleted the codex/issue-345-live-discovery branch July 26, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(harness): probe live discovery in isolated sandboxes

1 participant