Skip to content

feat(harness): add surface-aware harness selection - #464

Merged
solomonneas merged 1 commit into
mainfrom
feat/issue-344-surface-aware-harness
Jul 23, 2026
Merged

feat(harness): add surface-aware harness selection#464
solomonneas merged 1 commit into
mainfrom
feat/issue-344-surface-aware-harness

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • Add SurfaceRecord and surface-aware Selection so cursor-cli and cursor-gui keep separate fixture evidence while projecting through the shared cursor harness.
  • Gate install_selection on conformance availability: refuse externally_blocked / binary_not_found and external_only surfaces unless --projection-only is explicit; persist per-surface evidence to .brigade/surface-evidence.json.
  • Extend brigade harness install with --surface and --projection-only, returning typed CLI errors instead of tracebacks.

Closes #344.

Test plan

  • brigade work verify run --target . --command "pytest -q tests/test_surface_aware_install.py" --capture brigade-work
  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
  • Native (available), external-only (cursor-gui), and blocked-binary (binary_not_found) fixtures covered in tests/test_surface_aware_install.py
  • Separate cursor-cli / cursor-gui capability evidence preserved after install

Made with Cursor

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ac427cb4-c3c2-4279-9049-f31f9cca07e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/issue-344-surface-aware-harness

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 23, 2026
@solomonneas
solomonneas merged commit 9b2af9e into main Jul 23, 2026
28 checks passed
@solomonneas
solomonneas deleted the feat/issue-344-surface-aware-harness branch July 23, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(harness): add surface-aware harness selection

1 participant