feat(run): allow limits.scheduler roster default for --scheduler - #472
Merged
Conversation
The dag ready-queue scheduler shipped behind a CLI flag with a hardcoded waves default, so nothing ever ran on it unless every caller remembered --scheduler=dag. Rosters can now set scheduler = "waves"|"dag" under [limits]; the CLI flag still wins when passed, and the default remains waves when neither is set. Co-authored-by: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--scheduler=dagshipped in #447 but only as a per-invocation CLI flag with a hardcodedwavesdefault, so real runs (runbooks, hooks, operator habit) never actually exercised the DAG scheduler. This adds a roster-level default:scheduler = "waves" | "dag"under[limits].Precedence: CLI flag >
limits.scheduler>waves. Invalid values fail roster validation with the usuallimits.*error shape.Why
Dogfooding the DAG scheduler is the gating step for any future routing work, and a flag nobody passes produces no dogfooding. Config-level defaults are how a mode actually gets turned on across runbooks and daily runs.
Verify
./scripts/verifygreen through Brigade verify (run20260724-030655area, exit 0). New tests: roster accepts/rejects/defaultslimits.scheduler; CLI resolves roster default and flag override.Refs #447