Skip to content

fix(operator): count guidance paths by filesystem type in adopt plan - #509

Merged
solomonneas merged 1 commit into
mainfrom
issue/479-adopt-plan-miscount
Jul 24, 2026
Merged

fix(operator): count guidance paths by filesystem type in adopt plan#509
solomonneas merged 1 commit into
mainfrom
issue/479-adopt-plan-miscount

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • Fix brigade operator adopt plan guidance inventory so directories like memory/cards are classified with is_dir() and never inflate the guidance_files summary count.
  • Count present_count / present_dir_count from actual filesystem types instead of a hardcoded path set.
  • Apply the same directory-only rule to local_state inventory paths.
  • Extend regression coverage with a fixture containing card files under memory/cards/.

Closes #479

Test plan

  • ./scripts/verify
  • pytest tests/test_operator_cmd.py::test_adopt_plan_counts_guidance_files_and_dirs_separately -xvs

Made with Cursor

…479)

Classify guidance inventory entries with is_file()/is_dir() so directories
like memory/cards never inflate the guidance_files summary count, and apply
the same rule to local_state directory checks.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e0f2f464-7492-473e-a2d1-497e01b95832

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/479-adopt-plan-miscount

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 24, 2026
@solomonneas
solomonneas merged commit 873b226 into main Jul 24, 2026
28 checks passed
@solomonneas
solomonneas deleted the issue/479-adopt-plan-miscount branch July 26, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adopt plan: memory/cards directory miscounted as a guidance file

1 participant