fix(run): remove --deliberate mode per #442 kill decision - #512
Merged
Conversation
Drop the opt-in grounded-deliberation flag, planner/scope machinery, brigade.deliberation.v1 artifact emission, and runs show/watch/resume surfaces. The experiment remains recoverable from git history. Refs #442. Co-Authored-By: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the opt-in grounded-deliberation mode from
brigade runper the #442 kill decision. The mode landed in #452 and was bug-fixed in #470; this deletes it in working order. Recoverable from git history.--deliberatefrombrigade runand detach argv plumbingsrc/brigade/deliberation.pyandbrigade.deliberation.v1emission (all exports were deliberation-only; nothing moved)Historical experiment docs (
docs/deliberation-experiment.md,runs/experiment/) were not on this branch and were not touched.Closes #471. Refs #442.
Test plan
pytest -q(full suite) viabrigade work verify runruff check/ruff format --checkon touched filesmypy