Skip to content

fix(hooks): ignore .brigade artifact writes in closeout gate (#483) - #516

Merged
solomonneas merged 1 commit into
mainfrom
issue/483-closeout-gate-detached-runs
Jul 24, 2026
Merged

fix(hooks): ignore .brigade artifact writes in closeout gate (#483)#516
solomonneas merged 1 commit into
mainfrom
issue/483-closeout-gate-detached-runs

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • Stop the work-loop Stop hook from re-demanding verification when the only writes since capture are Brigade internal artifacts under .brigade/ (e.g. detached brigade run output in .brigade/runs/).
  • Treat brigade run bash like routed brigade work verify: skip PostToolUse write tracking so orchestration does not bump last_verification_write_at.
  • Add regression tests for artifact-only updates, post-capture source edits, and brigade run bash.

Closes #483.

Test plan

  • pytest tests/test_claude_hooks_runtime.py (70 passed)
  • ./scripts/verify (full suite green)

Made with Cursor

Detached brigade run output under .brigade/ no longer bumps
last_verification_write_at, and brigade run bash is excluded from
PostToolUse write tracking like routed verify already was.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a4d16b0-28e5-44de-8667-5b579d020da8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/483-closeout-gate-detached-runs

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 24, 2026
@solomonneas
solomonneas merged commit 2b7ca27 into main Jul 24, 2026
28 checks passed
@solomonneas
solomonneas deleted the issue/483-closeout-gate-detached-runs branch July 24, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

work-loop hook: closeout gate re-fires on detached-run artifact writes

1 participant