fix(hooks): adopt unwired Claude user settings on work hooks install - #525
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Legacy brigade-work-loop.py handlers in ~/.claude/settings.json can be adopted without Brigade repo wiring. Fixes #519. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brigade work hooks install/updatewhen.claude/settings.jsonalready exists even if Claude is not in the Brigade harness selection (Fixes harness sync: no working refresh path for stale deployed hooks (conflict on missing profile receipt, --adopt no-op) #519)..brigade/config.jsonexists but is unreadable (do not silently adopt)../scripts/verifymatches currentdocs/station-contract.mdwording on this base.Test plan
pytest tests/test_claude_hooks_settings_merge.py(adoption, refusal, malformed-config, update idempotence)brigade work hooks status --target ~theninstallonly if you want live home recovery (not done in this PR)Made with Cursor