Skip to content

fix(security): exclude Brigade state by default - #544

Merged
solomonneas merged 1 commit into
mainfrom
fix/529-security-exclude-paths
Jul 26, 2026
Merged

fix(security): exclude Brigade state by default#544
solomonneas merged 1 commit into
mainfrom
fix/529-security-exclude-paths

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

What changed

  • Default security scans to .brigade/** exclusion, including missing configs and newly generated configs.
  • Preserve an explicit exclude_paths = [] opt-in.
  • Reject unknown top-level keys and unknown keys in [suppressions] and [enrichment].
  • Keep [suppression_reasons] open for fingerprint keys.

Root cause

include_paths and exclude_paths were supported, parsed, and preserved. The scanner glob matcher treated ** as a literal prefix. Commit 55da125, already on main, corrected the scanner walk. This PR completes issue #529 by making Brigade state excluded by default and by rejecting config typos instead of accepting no-op keys.

No fingerprint-generation or suppression-matching code changed. That work remains scoped to issue #530.

Validation

  • brigade work verify run --target . --command "PY=$HOME/repos/brigade/.venv/bin ./scripts/verify" --capture brigade-work
  • Receipt: 20260726-190042-work-verify-51fd4f
  • Exit code: 0
  • Scratch repro built a center report, rescanned, and returned no .brigade/ scanned files or findings.
  • Unknown key exclude_pathz returned exit code 2.

Closes #529

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f0afe0bd-f753-4990-bcd0-e8d11a92f517

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/529-security-exclude-paths

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 26, 2026
@solomonneas
solomonneas marked this pull request as ready for review July 26, 2026 20:27
@solomonneas
solomonneas merged commit 4aa1862 into main Jul 26, 2026
27 of 28 checks passed
@solomonneas
solomonneas deleted the fix/529-security-exclude-paths branch July 26, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: exclude_paths is ignored, so .brigade/** self-scans and swamps the findings queue

1 participant