fix(verify): propagate harness session past extra env prefixes - #551
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The shell and Brigade process received both environment assignments. The second invocation hit verify result reuse because its command and tree matched case A.
_write_reused_receiptbuilt the cache-hit receipt without stampingBRIGADE_CLAUDE_SESSION; only_run_verify_commandsstamped fresh receipts.The fix moves the existing 16-hex stamping rule into
_stamp_harness_sessionand calls it from both fresh and reused receipt writers.Reproduction after the fix
Case A, fresh receipt:
{ "run_id": "20260726-203955-work-verify-f16366", "reused_from": null, "harness_session": { "harness": "claude", "fingerprint": "0123456789abcdef" } }Case B, two outer environment prefixes and a reused receipt:
{ "run_id": "20260726-203956-work-verify-0bc5b3", "reused_from": "20260726-203955-work-verify-f16366", "harness_session": { "harness": "claude", "fingerprint": "fedcba9876543210" } }The regression test invokes the real CLI through
/bin/shfor both shapes. Existing behavior for environment assignments inside--commandremains covered.Verification
./scripts/verify20260726-203339-work-verify-d83604completed0Closes #541.