fix(handoff): fail content guard lint on injection warnings - #559
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brigade handoff lint --content-guard.Wiring choice
This uses the in-guard option.
--content-guardalready calls the canonicalscan_handoff_injection_heuristics()detector, so its combined verdict now fails when either egress or injection fails. Info-only discussion remains non-blocking. No second detector was added.Before and after
Before, an egress-clean injection fixture printed warnings but exited 0:
After, each axis has its own verdict and the command exits 1:
The before output is recorded in Brigade receipt
20260726-210033-work-verify-08af8a.Coordination
Issue #490 owns the model_trials adversarial fixture. This PR does not change model_trials or add another fixture corpus. It uses the existing sample under
tests/fixtures/handoff_lint/injection/.This is a follow-up to #477 and #515, which added the scanner but left warning-level injection findings outside the command verdict.
Closes #555.
Verification
./scripts/verify: 4,309 passed, 3 skipped, 82.84% coverage. Brigade receipt20260726-210442-work-verify-21bcd1.pytest tests/test_handoff_injection_lint.py -q: passed. Brigade receipt20260726-210426-work-verify-98da75.20260726-211101-work-verify-f34c42.--content-guard: passed. Brigade receipt20260726-211138-work-verify-5eb8a7.