feat(work): capture-before-retry enforcement for failed verifies - #560
Merged
Conversation
Co-Authored-By: Cursor <cursoragent@cursor.com> Co-Authored-By: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockmode exits before creating a run, whileoffkeeps the prior behavior.Command identity
Identity is the ordered command list within one target repository. Each command is normalized with
shlex.splitandshlex.join, so whitespace and equivalent quoting do not create a new identity.Environment assignments inside
--commandremain part of identity because they affect execution. For example,VAR=1 falseandfalseare different commands. This follows the command handling implicated by #541.Exact matching does not stop an agent from changing the command string to bypass the check. Fuzzy matching is outside this issue.
Config
The existing
.brigade/config.jsonsurface accepts:{ "capture_before_retry": "warn" }Allowed values are
warn,block, andoff. The default iswarn, and the default value is omitted when Brigade writes the config.Tests
blockmode: exit 1 without creating a run.offmode: prior behavior.main.Verification
Final Brigade receipt:
20260726-210751-work-verify-dfeb03, exit 0.Manual scratch-repository demo:
The final run starts without a capture warning.
Closes #475.