fix(doctor): scope checks and group actionable output - #561
Merged
Conversation
Give doctor findings explicit target or operator scope and keep first-contact output limited to severity-grouped actions. Preserve status compatibility with scoped station checks. Co-authored-by: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetoroperatorscope with every check after doctor aggregation.--operatorfor host findings and--fullfor OK and INFO detail.brigade statusaccept optional scope metadata.Closes #556.
Scratch workspace reproduction
The same initialized scratch workspace was checked against current
mainand this branch on a host with operator state.Before
Current
mainprinted 51 lines with 44 visible target checks because the old condensation threshold was 50:After
The default report is 16 lines with six actionable target findings:
--operator --jsonreports 43 target checks and nine operator checks. Text output places the visible host findings under:Verification
The full gate passed 4,355 tests with three expected skips and 82.82% coverage.