Skip to content

docs(run): propose seat health failure taxonomy - #575

Merged
solomonneas merged 1 commit into
mainfrom
t3code/unify-seat-health-probes
Jul 26, 2026
Merged

docs(run): propose seat health failure taxonomy#575
solomonneas merged 1 commit into
mainfrom
t3code/unify-seat-health-probes

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Tracks #474.

Summary

  • inventory current roster, doctor, transport, dispatch, and receipt behavior
  • define a closed worker-failure taxonomy and adapter-owned seat health probe
  • specify additive receipt shapes, routing rules, migration, and compatibility
  • separate the implementation into five ordered S/M tracker items

This is a planning-only change. It does not implement the probe or alter run behavior.

Verification

  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
  • completed: 20260726-223358-work-verify-e5e891

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c91194a-399b-456b-9199-1273dab333a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/unify-seat-health-probes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas

Copy link
Copy Markdown
Collaborator Author

Blocking merge on a receipt-contract mismatch with merged #562:

  • The brigade.seat_health.v1 example omits integer schema_version.
  • The nested brigade.worker_failure.v1 example also omits integer schema_version.
  • The proposal says seat-health.json is updated in place after re-probes, but does not classify it as a latest-state snapshot or preserve probe events. That conflicts with #562s write-once/append-only policy unless the mutable snapshot semantics are explicit.
  • The new writers do not specify canonical sorted-key serialization, absent-versus-null rules, or reader compatibility.

Please rebase onto main and define those contract points before implementation is split from this proposal. An implementer following the current examples would produce receipts that fail the policy merged in #562.

@solomonneas
solomonneas marked this pull request as draft July 26, 2026 22:47
@solomonneas solomonneas self-assigned this Jul 26, 2026
@solomonneas
solomonneas marked this pull request as ready for review July 26, 2026 23:07
@solomonneas
solomonneas merged commit 31e4ad5 into main Jul 26, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant