fix(outcome): preserve colliding decision receipts - #603
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.jsondiscovery path.Root cause
Decision receipt paths used a second-resolution timestamp plus a lossy artifact slug. The mutable JSON helper then published with
os.replace, so a later decision selecting the same path silently replaced the earlier receipt.Verification
20260728-025815-work-verify-492587: 5 collision and exclusivity tests failed against the previous production behavior.20260728-030103-work-verify-35a8c4: deterministic slug collisions, atomic publication, 8 concurrent fixed-path writers, concurrent decision-writer retries, retry exhaustion, and legacy loading passed.20260728-025848-work-verify-cf2722: 119 outcome and scorecard tests passed.20260728-030128-work-verify-e1e0e0: 4,662 passed, 3 skipped, 82.93% coverage, with one shared editable-install failure intest_verify_reused_receipt_stamps_harness_session_from_outer_env_prefix.origin/mainbaseline receipt20260728-031031-work-verify-7a5022: the same isolated test failed with the sameNo module named brigadestderr under the shared virtualenv override. The test was not changed or skipped. CI's clean install is the deciding gate.Closes #564