feat(runs): graduate journal authority - #630
Merged
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BRIGADE_RUN_JOURNAL_AUTHORITYfrom the runtime path.snapshot-only path.
brigade.run.v1reader window, recovery path, and rollbackboundary.
Migration and reader notes
New runs persist both
lifecycle_journal_requested: trueandrun_journal_authority_requested: true. Existing runs are classified only fromtheir stored artifacts. Brigade does not add enrollment fields or create a
journal for an existing snapshot-only run.
run.jsonremains a schema-version-1 compatibility snapshot with additivefields. Previous readers can inspect it by ignoring unknown keys. Approval
pauses project the known nonterminal status
running. Previous writers must notresume, recover, or update a journal-authoritative run. Roll forward before
writing one of those run directories.
Verification
20260731-035716-work-verify-0425a2(446 passed).20260731-022543-work-verify-a46d80.20260731-022913-work-verify-725bfb.20260731-041740-work-verify-dc28e1(49 cited test names found).
20260731-023317-work-verify-b04a90.20260731-031308-work-verify-390e9c.20260731-031443-work-verify-4487de,20260731-031538-work-verify-95fa0c.20260731-033919-work-verify-926a8a,20260731-034226-work-verify-86c71b.20260731-034332-work-verify-f74938(123 passed).20260731-034936-work-verify-917f8d.20260731-040734-work-verify-f07456(2 passed),20260731-040744-work-verify-27163b(54 passed)../scripts/verify:20260731-040757-work-verify-815c12(5,531 passed, 3 skipped, 82.99% coverage).
Issue #568 closeout
The external grader must sign off on this table before issue #568 closes.
tests/test_run_projector.py::test_golden_replay_matches_expected_bytes,tests/test_run_projector.py::test_repeated_projection_is_byte_deterministicrun.jsonfield is mapped or derived.tests/test_run_projector.py::test_full_field_fixture_preserves_deep_equality_and_copies_nested_values,tests/test_run_projector.py::test_unknown_base_key_raises_bounded_unknown_snapshot_field_errortests/test_run_journal.py::test_idempotent_replay_returns_existing_event_without_second_appendtests/test_run_journal.py::test_same_idempotency_key_different_digest_raises_without_mutationtests/test_run_lifecycle.py::test_checkpoint_failure_leaves_journal_and_run_json_unchanged,tests/test_run_journal.py::test_append_event_rejects_partial_os_write,tests/test_run_lifecycle.py::test_retry_after_interruption_reuses_committed_event, real subprocessSIGKILL:tests/test_run_checkpoint.py::test_write_text_atomic_sigkill_during_temp_window_preserves_one_valid_payloadtests/test_run_journal.py::test_recover_partial_tail_quarantines_suffix_then_truncates,tests/test_runs_cmd.py::test_runs_recover_quarantines_partial_journal_tail_then_verifiesrun.jsonrebuilds to the same observable state.tests/test_runs_cmd.py::test_runs_recover_restores_missing_run_json_from_latest_checkpoint,tests/test_runs_cmd.py::test_runs_recover_preserves_corrupt_run_json_and_restores_from_checkpointtests/test_run_journal.py::test_read_journal_detects_sequence_gap_without_mutation,tests/test_run_journal.py::test_read_journal_detects_previous_digest_mismatch_without_mutation,tests/test_run_events.py::test_validate_event_rejects_unknown_schema_version,tests/test_run_events.py::test_validate_event_rejects_unknown_event_type,tests/test_run_shadow.py::test_stale_projector_version_gate_returns_only_stale_reasonwatch,show,steer,interrupt,recover, andresumeremain compatible.tests/test_runs_cmd.py::test_runs_watch_surfaces_stale_lock_recovery_and_returns_nonzero,tests/test_runs_cmd.py::test_runs_show_prints_summary,tests/test_run_control.py::test_run_records_control_socket_and_cli_steers_live_worker,tests/test_run_control.py::test_cli_interrupt_leaves_live_worker_resumable,tests/test_runs_cmd.py::test_runs_recover_accepts_covered_paired_status_event_and_preserves_fields,tests/test_run_resume.py::test_resume_reattaches_and_resynthesizeslifecycle.jsonlstill loads.tests/test_run_lifecycle.py::test_legacy_run_dir_stays_snapshot_only_with_flag_on,tests/test_runs_cmd.py::test_runs_recover_no_journal_legacy_dead_owner_marks_terminalrun.jsonto the previous release.tests/test_aboyeur.py::test_default_authority_run_json_remains_readable_by_previous_v1_reader, receipt20260731-022543-work-verify-a46d80tests/test_runs_cmd.py::test_runs_recover_prints_pending_dispatch_only_after_validated_recovery,tests/test_doctor.py::test_doctor_validates_checkpoint_before_reporting_pending_dispatchtests/test_run_lifecycle.py::test_record_approval_pause_commits_events_snapshot_and_releases_lock,tests/test_daily_driver_cmd.py::test_daily_approval_pauses_real_run_and_cli_resume_consumes_store_oncetests/test_runs_cmd.py::test_resume_paused_records_terminal_daily_decision_without_consuming,tests/test_runs_cmd.py::test_rejected_marker_stays_approval_aware_and_never_reaches_provider,tests/test_runs_cmd.py::test_resume_paused_refuses_stale_daily_reference_before_consuming,tests/test_runs_cmd.py::test_resume_paused_daily_legacy_consumed_store_fails_closed,tests/test_runs_cmd.py::test_redeemed_retry_refuses_changed_source_decision,tests/test_runs_cmd.py::test_redeemed_retry_revalidates_current_blockers,tests/test_runs_cmd.py::test_redeemed_retry_refuses_claim_for_another_run,tests/test_runs_cmd.py::test_redeemed_reconciliation_holds_source_lock_through_journal_committests/test_work_cmd_services.py::test_tools_redeemed_action_crash_reconciles_without_second_execution,tests/test_daily_driver_cmd.py::test_daily_approval_pauses_real_run_and_cli_resume_consumes_store_once,tests/test_runs_cmd.py::test_redeemed_daily_retry_requires_completed_action_receipt,tests/test_runs_cmd.py::test_redeemed_daily_retry_refuses_tampered_action_receipt,tests/test_runs_cmd.py::test_redeemed_reconciliation_holds_source_lock_through_journal_commit, RED receipts20260731-031308-work-verify-390e9cand20260731-033919-work-verify-926a8a, GREEN receipts20260731-031443-work-verify-4487de,20260731-031538-work-verify-95fa0c,20260731-031504-work-verify-560b9c, and20260731-034226-work-verify-86c71btests/test_runs_cmd.py::test_approval_wait_uses_previous_reader_nonterminal_status,tests/test_runs_cmd.py::test_previous_resume_reader_refuses_new_approval_wait_before_providertests/test_run_events.py::test_validate_event_rejects_unknown_payload_key_with_bounded_diagnostic,tests/test_run_events.py::test_validate_event_rejects_private_data_payload_keys20260730-102257-work-verify-89936b, MiseLedger item42fa84331436564d51d01075, artifact SHA-256d18ef7f2fd042332b281810d4fd122c8888a877e5f0eef45f73b5ed104874f50: 1,000 runs, 2,000 append samples, p50 5,332,407 ns, p95 8,031,038 ns, p99 11,976,013 ns, max 32,024,437 ns20260731-023317-work-verify-b04a90provespyproject.tomlis unchanged from pre-journal commit1b143bf79b7653999d2f3895338a812978718ea0, changed-runtime source audit receipt20260731-034936-work-verify-917f8dcoversaboyeur.py,runs_cmd.py, the Daily run loop, both approval stores, direct run callers, and journal modules, and final./scripts/verifyreceipt20260731-040757-work-verify-815c12completed with 5,531 passed, 3 skipped, and 82.99% coverageRefs #568.