test(runs): pin previous-release run.json reader to v0.25.0 fixture - #640
Merged
Conversation
Replace the ad-hoc previous-v1-reader closure with a versioned contract derived from the last pre-journal tag, covering authoritative, paused, and legacy snapshots. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.25.0(last release before journal authority feat(runs): add lifecycle journal kernel #607).tests/fixtures/run-compat/v1-reader-contract.json.test_default_authority_run_json_remains_readable_by_previous_v1_readerto validate authoritative, paused (status: runningplusapproval_referenceand journal cursor fields), and legacy snapshots against that fixture.Acceptance criteria → tests
tests/fixtures/run-compat/v1-reader-contract.json(derived_from.tag/comment)tests/test_aboyeur.py::test_default_authority_run_json_remains_readable_by_previous_v1_reader_previous_v1_readerloads the fixture contractVerification
brigade work verify run --target . --command "./scripts/verify" --capture brigade-work20260801-032148-work-verify-fb1411Notes
src/changes.Closes #637.
Made with Cursor