Skip to content

test(runs): pin previous-release run.json reader to v0.25.0 fixture - #640

Merged
solomonneas merged 1 commit into
mainfrom
fix/637-v1-reader-fixture
Aug 1, 2026
Merged

test(runs): pin previous-release run.json reader to v0.25.0 fixture#640
solomonneas merged 1 commit into
mainfrom
fix/637-v1-reader-fixture

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the closure-based previous-v1-reader compatibility check with a versioned fixture derived from tag v0.25.0 (last release before journal authority feat(runs): add lifecycle journal kernel #607).
  • Pin the accepted nonterminal status set, required fields, and ignore-unknown-keys parse behavior in tests/fixtures/run-compat/v1-reader-contract.json.
  • Expand test_default_authority_run_json_remains_readable_by_previous_v1_reader to validate authoritative, paused (status: running plus approval_reference and journal cursor fields), and legacy snapshots against that fixture.

Acceptance criteria → tests

Acceptance Test
Fixture names its source tag and is not editable without a visible diff tests/fixtures/run-compat/v1-reader-contract.json (derived_from.tag / comment)
Tests cover authoritative, legacy, and paused snapshots against the fixture tests/test_aboyeur.py::test_default_authority_run_json_remains_readable_by_previous_v1_reader
Old closure-based test is removed or delegates to the fixture Same test; _previous_v1_reader loads the fixture contract

Verification

  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
  • Receipt: 20260801-032148-work-verify-fb1411

Notes

  • Tests and one fixture file only; no src/ changes.
  • External grader review before merge; do not merge from this PR.

Closes #637.

Made with Cursor

Replace the ad-hoc previous-v1-reader closure with a versioned contract
derived from the last pre-journal tag, covering authoritative, paused,
and legacy snapshots.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f1b47c6-3fa6-4070-938a-e5598cb21f2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run-projector: pin previous-release reader compatibility against a real fixture

1 participant