fix(runs): strip private recovery-checkpoint bodies at export (#636) - #646
Merged
Conversation
Keep local recovery semantics intact while ensuring verify-archive and other export copies only carry the closed artifact-reference shape. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
events/recovery-checkpoints/areprivacy_class: privateand must be stripped to the closed artifact-reference shape (path,sha256,media_type,byte_size,privacy_class), replaced, or refused with a bounded error naming the privacy class._archive_verify_runafter the byte-identical copy check (source run dirs unchanged). Document the rule next toFORBIDDEN_PAYLOAD_KEYSinrun_events.py.Closes #636.
Audited surfaces (grep:
recovery-checkpoints/validate_checkpoint/recover_from_checkpoint)run_checkpoint.validate_checkpoint/recover_from_checkpointruns_cmd._recover_from_checkpoint/runs_cmd.recoverdoctor._check_recovery_checkpoints/validate_checkpointrun_redaction._validate_checkpoint_artifactsaboyeur/run_lifecycle→write_checkpointwork_cmd.verification._archive_verify_run(shutil.copytree)receipts_cmdMiseLedger export (*/receipt.json,*/run.json)run.jsononly)events/recovery-checkpoints/todaytools_cmdcheckpoint storeAcceptance → tests
test_strip_checkpoint_bodies_for_export_replaces_private_body,test_assert_export_tree_refuses_checkpoint_body,test_refuse_checkpoint_body_export_names_privacy_class,test_archive_verify_run_strips_recovery_checkpoint_bodiestest_local_recovery_round_trips_after_export_strip_of_copy(plus existingtest_recover_from_checkpoint_*)Verification
Receipt:
20260801-035934-work-verify-52e52d(status: completed, exit=0).Test plan
./scripts/verifyvia BrigadeMade with Cursor