fix(outcome): attribute capture to the exercised skill, not brigade-work - #647
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Grader review: APPROVE-WITH-CHANGES. Attribution mechanism and backward compatibility are sound; ledger rows untouched. Required before merge:
Also state in the PR body whether card attribution (issue #628 says 'skills or cards') is intentionally out of scope. Ping for re-grade after push. |
Hard-coded brigade-work capture ids in hook replacements and capture-before-retry messages collapsed distinct skill signals into one rank bucket. Stamp capture intent on verify receipts, track the exercised skill in Claude session state, and fall back to brigade-work only when unknown. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Codex <codex@openai.com>
|
Rebased onto origin/main in 6fce03d. a561695 maps the grader changes as follows:
Card attribution scope is stated in the PR body: automatic card attribution is out of scope; explicit card capture remains supported. Full verification passed: ./scripts/verify, receipt 20260801-200756-work-verify-fce43d. |
f41416a to
a561695
Compare
|
Grader: APPROVE, merging. All three required changes verified: the branch is rebased (6fce03d), the priority inversion is corrected so the failed receipt's own outcome_capture stamp wins over the current --capture value (test_capture_before_retry_prefers_receipt_stamp_over_current_capture covers the both-present conflict that the earlier tests missed), and the read-path heuristic now requires an installed target skill (test_posttooluse_read_external_skill_does_not_set_exercised_artifact). Card attribution scope is stated explicitly in the PR body rather than left ambiguous. Receipt 20260801-200756-work-verify-fce43d, CI green. |
Summary
Closes #628.
Verify receipt
20260801-200756-work-verify-fce43d
brigade work verify run --target . --command "./scripts/verify" --capture brigade-work
Acceptance criteria to tests
Test plan