fix(outcome): forgive candidate regressions when clears outnumber them - #648
Merged
Conversation
A single verified hurt permanently withheld an unchanged candidate cohort even after later clears greatly outnumbered it. Withhold only while helped <= hurt, and allow install once clears outnumber regressions and meet install_min_helped. Promoted demotion stays a separate policy. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helped <= hurt; they install whenhelped >= install_min_helpedand clears strictly outnumber regressions.Closes #629.
Verify receipt
20260801-042517-work-verify-aa3a0cAcceptance criteria → tests
helped=10 hurt=1installs (forgiveness)test_decide_installs_candidate_when_later_clears_outnumber_regressiontest_decide_withholds_candidate_when_regressions_are_not_outnumberedtest_decide_scores_new_fingerprint_cohort_separately_from_regressed_cohorttest_decide_rolls_back_a_promoted_artifact_on_regressionTest plan
tests/test_outcome.py+ scorecard suites greenbrigade work verify run --target . --command "./scripts/verify" --capture brigade-workMade with Cursor