fix: reach active-window fallbacks without xdotool - #31
Merged
Conversation
Doctor claimed gnome-screenshot/scrot while capture bailed when xdotool was missing. Plan the X11 active chain so those helpers stay reachable, and report only helpers capture/text paths can actually invoke. Closes #19 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capture --target activeno longer early-returns whenxdotoolis missing;gnome-screenshot -w/scrot -ustay in the fallback chain.LINUX_REACHABLE_HELPERSonly (addsflameshot/xprop, drops unusedspectacle/gdbus) andx11-active-windowmatches the same readiness predicate.Closes #19
Test plan
brigade work verify run --target . --command "./scripts/verify" --capture brigade-work(118 tests)codex review --commit— no findingsMade with Cursor