Skip to content

fix: reach active-window fallbacks without xdotool - #31

Merged
solomonneas merged 1 commit into
masterfrom
t3code/fix-issue-19-active-fallbacks
Jul 25, 2026
Merged

fix: reach active-window fallbacks without xdotool#31
solomonneas merged 1 commit into
masterfrom
t3code/fix-issue-19-active-fallbacks

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Summary

  • capture --target active no longer early-returns when xdotool is missing; gnome-screenshot -w / scrot -u stay in the fallback chain.
  • Doctor reports LINUX_REACHABLE_HELPERS only (adds flameshot/xprop, drops unused spectacle/gdbus) and x11-active-window matches the same readiness predicate.
  • Unit tests cover the planner and doctor/helper alignment.

Closes #19

Test plan

  • brigade work verify run --target . --command "./scripts/verify" --capture brigade-work (118 tests)
  • codex review --commit — no findings
  • CI green on PR

Made with Cursor

Doctor claimed gnome-screenshot/scrot while capture bailed when xdotool
was missing. Plan the X11 active chain so those helpers stay reachable,
and report only helpers capture/text paths can actually invoke.

Closes #19

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c82916a1-9d0a-46a3-8804-0f8fc3883bff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/fix-issue-19-active-fallbacks

Comment @coderabbitai help to get the list of available commands.

@solomonneas
solomonneas merged commit 8199652 into master Jul 25, 2026
4 checks passed
@solomonneas
solomonneas deleted the t3code/fix-issue-19-active-fallbacks branch July 25, 2026 04:13
@solomonneas solomonneas self-assigned this Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: active-target fallbacks unreachable without xdotool; doctor overstates helpers

1 participant