feat: move off of systems.json and move Systems and SystemWaypoint into database#31
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 64.18% 66.61% +2.42%
==========================================
Files 144 149 +5
Lines 7209 7332 +123
==========================================
+ Hits 4627 4884 +257
+ Misses 2582 2448 -134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes FileSystem from all arguments.
What was previously SystemsCache is now SystemsSnapshot
and a new class "SystemsStore" is now just a wrapper around
db apis.
SystemRecords (just symbol, type, x, y and waypointSymbols)
are stored in one table, and SystemWaypoints are stored in
another.
Attempted to move most places off of using SystemsSnapshot
when possible, but there are still many more that can move.
Probably SystemsSnapshot splits into SystemRecordSnapshot
and SystemWaypointSnapshot, but for now it's combined.