Skip to content

feat: move off of systems.json and move Systems and SystemWaypoint into database#31

Merged
eseidel merged 30 commits into
mainfrom
es/systems_cache
May 6, 2025
Merged

feat: move off of systems.json and move Systems and SystemWaypoint into database#31
eseidel merged 30 commits into
mainfrom
es/systems_cache

Conversation

@eseidel

@eseidel eseidel commented May 6, 2025

Copy link
Copy Markdown
Owner

This also removes FileSystem from all arguments.

What was previously SystemsCache is now SystemsSnapshot
and a new class "SystemsStore" is now just a wrapper around
db apis.

SystemRecords (just symbol, type, x, y and waypointSymbols)
are stored in one table, and SystemWaypoints are stored in
another.

Attempted to move most places off of using SystemsSnapshot
when possible, but there are still many more that can move.

Probably SystemsSnapshot splits into SystemRecordSnapshot
and SystemWaypointSnapshot, but for now it's combined.

@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.47337% with 66 lines in your changes missing coverage. Please review.

Project coverage is 66.61%. Comparing base (cb42378) to head (1994bcf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/lib/cache/waypoint_cache.dart 31.81% 15 Missing ⚠️
packages/cli/lib/behavior/seeder.dart 0.00% 13 Missing ⚠️
...kages/types/lib/src/snapshot/systems_snapshot.dart 62.96% 10 Missing ⚠️
packages/cli/lib/central_command.dart 50.00% 9 Missing ⚠️
packages/db/lib/db.dart 75.00% 4 Missing ⚠️
packages/db/lib/src/queries/market_listing.dart 0.00% 3 Missing ⚠️
packages/cli/lib/behavior/system_watcher.dart 0.00% 2 Missing ⚠️
packages/cli/lib/logic/advance.dart 33.33% 2 Missing ⚠️
packages/cli/lib/nav/route.dart 90.90% 2 Missing ⚠️
packages/cli/lib/plan/supply_chain.dart 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   64.18%   66.61%   +2.42%     
==========================================
  Files         144      149       +5     
  Lines        7209     7332     +123     
==========================================
+ Hits         4627     4884     +257     
+ Misses       2582     2448     -134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eseidel eseidel merged commit 3367b5c into main May 6, 2025
2 checks passed
@eseidel eseidel deleted the es/systems_cache branch May 6, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant