fix(checkpoint): ignore out-of-workspace rewind snapshots#4274
Open
GTC2080 wants to merge 1 commit into
Open
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4246
Problem
Code-only rewind can fail on Windows with an error like
rewind code: checkpoint path ... escapes workspace ...when a checkpoint contains a path outside the active project root. In that state the desktop shows the rewind action, but the restore aborts before the user's project files are rolled back.Root cause
Checkpoint snapshots recorded writer-preview paths verbatim. In project tabs, that allowed absolute paths outside
WorkspaceRoot(for example Reasonix-managed project or memory files) to be persisted beside normal workspace edits.RestoreCodelater rejected those paths with the workspace escape guard, which is safe but made one out-of-scope snapshot fail the whole code rewind. Existing sessions could keep hitting the same failure because the bad path was already persisted.Fix
filepath.Rel, avoiding fragile string-prefix comparisons.Validation
go test ./internal/checkpoint -run 'TestRestoreSkipsPersistedPathEscape|TestSnapshotSkipsOutsideWorkspaceWithoutBreakingRestore|TestSnapshotStoresWorkspaceRelativePaths' -count=1gofmt -l .git diff --check HEAD^ HEADgo test ./...go test ./...indesktop/go vet ./...go vet ./...indesktop/go build ./...go build ./...indesktop/npm run test:allindesktop/frontendnpm run buildindesktop/frontend