fix: feishu output issues (topic_group, UTF-8 truncation, ThreadID)#4353
Open
haozicnm wants to merge 1 commit into
Open
fix: feishu output issues (topic_group, UTF-8 truncation, ThreadID)#4353haozicnm wants to merge 1 commit into
haozicnm wants to merge 1 commit into
Conversation
…son.Marshal error handling)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several issues found in the Feishu/Lark bot output code analysis.
Changes
🔴 Critical fixes
handleMessagenow recognizestopic_groupchat type (2f80b50)"group", missing Feishu topic groups (topic_group)RequireMentiongatinghandleSDKMessage) which already had thisUTF-8 safe tool output truncation (render.go)
len(output) > 500to rune-basedlen([]rune(output)) > 500🟡 Improvements
Added
ThreadIDfield tofeishuMsgEventstructthread_idbut it wasn't being parsedhandleMessagenow extracts and propagatesThreadIDtoInboundMessageProper error handling in
sendCardjson.Marshalerror was silently ignored with_fmt.Errorf("feishu card marshal: %w", err)Testing
go build