refactor: remove old banks keys #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baruchiro
changed the title
baruchiro
changed the title
baruchiro
changed the title
|
hi. I don't have those institutes. I understand they don't exists any more? if so lets merge it |
|
i have them both, i can test it today later the evening, i will update it thats what you're waiting for |
|
@esakal They are just old keys that replcaed with new keys, if you will look closely on the PR diff, you will se they are directed into scrapers that are also directed by new keys:
|
|
If this helps I just test PR with my creds for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: the
hapoalimBeOnlinewas replaced withhapoalimand theleumiCardwas replaced withmax. All the new keys are already there for months.