fix(beinleumi): support both new and old UI #908
+37
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
src/scrapers/base-beinleumi-group.ts
file to enhance compatibility with both the new and old user interfaces of the banking website. The changes focus on updating the selectors and improving the resilience of iframe handling.Key updates include:
UI Compatibility Enhancements:
getPossibleLoginResults
function to recognize patterns from both the new and old UI.waitForPostLogin
function to wait for elements specific to both UI versions.Iframe Handling Improvements:
getTransactionsFrame
to handle cases where the iframe might not be immediately available.IFRAME_NAME
for the iframe name to avoid hardcoding it multiple times.Account Data Fetching:
fetchAccounts
to handle both single and multiple account scenarios more robustly, and to use the appropriate page or iframe based on availability.