Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beinleumi): support both new and old UI #908

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikash
Copy link
Collaborator

@erikash erikash commented Mar 15, 2025

This pull request includes several updates to the src/scrapers/base-beinleumi-group.ts file to enhance compatibility with both the new and old user interfaces of the banking website. The changes focus on updating the selectors and improving the resilience of iframe handling.

Key updates include:

UI Compatibility Enhancements:

  • Updated getPossibleLoginResults function to recognize patterns from both the new and old UI.
  • Enhanced waitForPostLogin function to wait for elements specific to both UI versions.

Iframe Handling Improvements:

  • Introduced a retry mechanism in getTransactionsFrame to handle cases where the iframe might not be immediately available.
  • Defined a constant IFRAME_NAME for the iframe name to avoid hardcoding it multiple times.

Account Data Fetching:

  • Modified the logic in fetchAccounts to handle both single and multiple account scenarios more robustly, and to use the appropriate page or iframe based on availability.

@erikash erikash changed the title Support both new and old versions of the beinleumi scraper fix(beinleumi): Support both new and old UI Mar 15, 2025
@erikash erikash changed the title fix(beinleumi): Support both new and old UI fix(beinleumi): support both new and old UI Mar 15, 2025
@Nic3Guy
Copy link
Contributor

Nic3Guy commented Mar 15, 2025

@erikash please don't merge this yet, I test it (I'm on the new UI) and currently it fails, I will try to adjust.
image

P.s. sorry for missing that some people still have the old UI, I didn't think about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants