fix: False-positive no-extraneous-import when using the tsconfig > paths alias import#408
Merged
aladdin-add merged 2 commits intoeslint-community:masterfrom Feb 23, 2025
MorevM:master
Merged
fix: False-positive no-extraneous-import when using the tsconfig > paths alias import#408aladdin-add merged 2 commits intoeslint-community:masterfrom MorevM:master
no-extraneous-import when using the tsconfig > paths alias import#408aladdin-add merged 2 commits intoeslint-community:masterfrom
MorevM:master
Conversation
Author
|
The falling type test is not caused by this change, and I honestly have little desire to fix it :) |
|
Yes, the master branch is also failing (it may be due to recent eslint type changes). I'll try to investigate it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379
I decided to be as minimalistic as possible in the changes (still, it fixes the problem) :)
The original solution proposed in the issue didn't work for me, because calculating
resolverConfigdepends onmoduleType, but calculating the correctmoduleTyperequires partially fillingresolverConfig(in particularresolverConfig.alias), which would result in calling a separate method twice, which is obviously less performant, so I just inserted the necessary check into thegetModuleTypedefinition.