docs: add step with example selector for new language #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rySelectorPlaceholder
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
changed the title
esquerySelectorPlaceholder
lumirlumir
changed the title
esquerySelectorPlaceholder
eslint-github-bot
bot
added
the
documentation
lumirlumir
added
the
accepted
lumirlumir
approved these changes
May 15, 2025
| @@ -23,6 +23,7 @@ Add an SVG logo into the `public/languages/` directory. | |||
| 1. Default the default code for the new language (such as `defaultJsonCode` or `defaultCssCode`). | |||
| 1. Add an entry in the `defaultCode` variable for the new language's default code. | |||
| 1. Export a variable containing the default options for the new language (such as `defaultJsonOptions` or `defaultCssOptions`). | |||
| 1. Add an entry to the `esquerySelectorPlaceholder` constant for the new language, using an appropriate example selector. | |||
There was a problem hiding this comment.
It would be great if we could actually link to where exactly this is in code? That would be better for someone newly exploring the repo? WDYT
|
Just to double-check, are the rest of the steps still accurate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rySelectorPlaceholder
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
update docs to ensure it's up-to-date with all of the required steps
Related Issues
Is there anything you'd like reviewers to focus on?