Skip to content

feat: add ecmaVersion 2026#114

Merged
nzakas merged 3 commits into
eslint:mainfrom
xbinaryx:es2026
Jul 9, 2025
Merged

feat: add ecmaVersion 2026#114
nzakas merged 3 commits into
eslint:mainfrom
xbinaryx:es2026

Conversation

@xbinaryx

@xbinaryx xbinaryx commented Jul 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Adds ecmaVersion: 2026 to enable parsing new syntax from the Explicit Resource Management proposal, that is using and await using declarations.

What changes did you make? (Give an overview)

  • Updated espree and eslint-scope dependencies
  • Set the latest ECMA version to 2026
  • Added both ECMAScript 2025 and 2026 as selectable version options
  • Updated the Version type to manually include 2026 since espree hasn't updated its type definitions yet

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify

netlify Bot commented Jul 6, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 5309d6d
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/686e5fc6823e240008fe7727
😎 Deploy Preview https://deploy-preview-114--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lumirlumir
lumirlumir reviewed Jul 6, 2025
View reviewed changes

@lumirlumir lumirlumir left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments to the team about the mismatch between espree and @types/espree.

The rest looks good to me 👍

Comment thread src/hooks/use-ast.ts Outdated
Comment thread src/hooks/use-explorer.ts
@lumirlumir lumirlumir added this to Triage Jul 6, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Jul 6, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Feedback Needed in Triage Jul 6, 2025
@lumirlumir lumirlumir mentioned this pull request Jul 6, 2025
Closed
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 9, 2025
@lumirlumir lumirlumir moved this from Feedback Needed to Implementing in Triage Jul 9, 2025
lumirlumir
lumirlumir approved these changes Jul 9, 2025
View reviewed changes

@lumirlumir lumirlumir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Would like @nzakas to verify before merging.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Jul 9, 2025
nzakas
nzakas approved these changes Jul 9, 2025
View reviewed changes

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 68d1182 into eslint:main Jul 9, 2025
8 checks passed
@github-project-automation github-project-automation Bot moved this from Second Review Needed to Complete in Triage Jul 9, 2025
@xbinaryx xbinaryx changed the title feat: add ecmaVersion: 2026 feat: add ecmaVersion 2026 Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

@lumirlumir lumirlumir lumirlumir approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion feature

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xbinaryx @nzakas @lumirlumir