Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Sep 17, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR is a follow-up to eslint/js#664 and eslint/generator-eslint#224.

In this PR, I've replaced npm-run-all with a native script.

Since npm-run-all is only used in a few places and, according to #137, is deprecated, removing this dev dependency would reduce maintenance overhead. Also, the existing script can be simplified by removing the npm-run-all package.

I've referenced the following script, which follows our package.json conventions.

What changes did you make? (Give an overview)

In this PR, I've replaced npm-run-all with a native script.

Related Issues

Ref: #137, eslint/js#664, eslint/generator-eslint#224

Is there anything you'd like reviewers to focus on?

N/A

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit fc0de75
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/68cabe62701de0000891c7e0
😎 Deploy Preview https://deploy-preview-153--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslintbot eslintbot added this to Triage Sep 17, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 17, 2025
@lumirlumir lumirlumir marked this pull request as ready for review September 17, 2025 13:59
@lumirlumir lumirlumir requested review from a team September 17, 2025 14:00
@lumirlumir lumirlumir changed the title chore: remove deprecated npm-run-all package chore: replace deprecated npm-run-all package Sep 17, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 17, 2025
@aladdin-add aladdin-add merged commit 919da3a into main Sep 17, 2025
10 checks passed
@aladdin-add aladdin-add deleted the chore-remove-deprecated-npm-run-all-package branch September 17, 2025 15:27
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants