Skip to content

Conversation

@amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Problems with Double Persist

  • Both persist middlewares use the same store name
  • Two storage mechanisms are fighting each other, unclear which storage takes precedence

What changes did you make? (Give an overview)

Removed redundant presist middleware layer

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 8cb1457
🔍 Latest deploy log https://app.netlify.com/projects/eslint-code-explorer/deploys/68f0101b5ab9090008fd669d
😎 Deploy Preview https://deploy-preview-192--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslintbot eslintbot added this to Triage Oct 15, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 15, 2025
@lumirlumir lumirlumir changed the title chore: remove redundant presist refactor: remove redundant presist Oct 17, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 17, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Oct 17, 2025
@lumirlumir lumirlumir self-requested a review October 17, 2025 10:36
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another review before merging.

(I've marked the PR title as refactor, since it's a change to production code.)

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Oct 17, 2025
@lumirlumir lumirlumir requested a review from a team October 17, 2025 12:47
Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kecrily kecrily merged commit 8ce3296 into main Oct 19, 2025
9 checks passed
@kecrily kecrily deleted the remove-redundant-presist branch October 19, 2025 16:17
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants