-
-
Notifications
You must be signed in to change notification settings - Fork 17
chore: simplify configuration files #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies various configuration files by removing unnecessary fields and streamlining exports. The changes aim to reduce configuration complexity while maintaining functionality.
- Simplified
postcss.config.jsto use direct export instead of intermediate variable - Removed
versionfield frompackage.jsonandpackage-lock.json(appropriate for private packages) - Updated
tailwind.config.jscontent paths to remove non-existent directories - Reorganized
eslint.config.jsby movingglobalIgnoresto the beginning and attempting to simplify config spreading
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.js | Moved globalIgnores to beginning, removed spread operator for TypeScript ESLint config, and removed react-hooks plugin registration |
| package.json | Removed version field and reordered file extensions in lint-staged config |
| package-lock.json | Removed version field to match package.json changes |
| postcss.config.js | Simplified to direct export without intermediate variable assignment |
| tailwind.config.js | Updated content paths to only include ./src/**/*.{ts,tsx}, removing non-existent directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amareshsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Leaving it open for DMartens's review.
DMartens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, good catches.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've simplified the configuration files as follows:
eslint.config.js: By using thedefineConfighelper, the spread (...) fortseslint.configs.recommendedwas unnecessary, so I removed it. I also removed theplugins.react-hooksfield since there are noreact-hooksoverrides inrules.package.json: Sincecode-exploreris not an npm-published package, theversionfield was unnecessary, so I removed it.postcss.config.js: Simplified to use a default export directly, removing the need for a separate variable assignment.tailwind.config.js: Removed the root-levelpages,components, andappentries because those directories do not exist.What changes did you make? (Give an overview)
In this PR, I've simplified the configuration files.
Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A