Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup checks for update of branch main and for PRs #86

Merged
merged 5 commits into from
Mar 3, 2025
Merged

ci: setup checks for update of branch main and for PRs #86

merged 5 commits into from
Mar 3, 2025

Conversation

pkerschbaum
Copy link
Contributor

@pkerschbaum pkerschbaum commented Mar 1, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request?

Add CI which runs

  • for every push on branch main
  • and for every PR

What changes did you make? (Give an overview)

  • ci: setup checks for update of branch main and for PRs
  • chore: add compile script which runs tsc type checking
  • ci: fail when ESLint warnings exist

Related Issues

Resolves #48
Supersedes #70

Is there anything you'd like reviewers to focus on?

Note that #85 is needed first for the CI to finish successfully.

@netlify Netlify
Copy link

netlify bot commented Mar 1, 2025 •
edited
Loading

✅ Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit ef53ad0
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/67c5f2efb062a80008506d0e
😎 Deploy Preview https://deploy-preview-86--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkerschbaum pkerschbaum mentioned this pull request Mar 1, 2025
Open
1 task
nzakas
nzakas reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#85 has been merged. Just a note about our standard script names, but otherwise this looks good.

@pkerschbaum pkerschbaum force-pushed the ci/setup-checks-for-updates-of-main-branch-and-prs branch from 9de6806 to d08671b Compare March 3, 2025 18:03
pkerschbaum and others added 2 commits March 3, 2025 19:04
@pkerschbaum @nzakas
Update package.json
c8e1cc9 
Co-authored-by: Nicholas C. Zakas <[email protected]>
@pkerschbaum
adapt CI
b206744
@pkerschbaum pkerschbaum requested a review from nzakas March 3, 2025 18:06
nzakas
nzakas approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

nzakas
nzakas reviewed Mar 3, 2025
View reviewed changes
nzakas
nzakas approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There we go. Thanks!

@nzakas nzakas merged commit da3e1e5 into eslint:main Mar 3, 2025
8 checks passed
@pkerschbaum pkerschbaum deleted the ci/setup-checks-for-updates-of-main-branch-and-prs branch March 3, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Add CI to the repo.
2 participants
@pkerschbaum @nzakas