Skip to content

refactor: remove accordion behavior for non-array nodes #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzakas merged 1 commit into from
Apr 21, 2025
Merged

refactor: remove accordion behavior for non-array nodes #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions src/components/scope/scope-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,43 @@ export const ScopeItem: FC<ScopeItemProperties> = ({
([name]) => !name.startsWith("__"),
);

if (isArray) {
return (
<AccordionItem
value={path + "." + index + "." + key}
className={cn(
"border border-card rounded-lg overflow-hidden",
isEsqueryMatchedNode && "border-primary border-4",
)}
>
<AccordionTrigger className="text-sm bg-card px-4 py-3 capitalize">
{`${Math.max(index, 0)}. ${key}`}
</AccordionTrigger>
<AccordionContent className="p-4 border-t">
<div className="space-y-1">
{properties.map((item, index) => (
<TreeEntry
key={item[0]}
data={item}
path={path + "." + index}
esqueryMatchedNodes={esqueryMatchedNodes}
/>
))}
</div>
</AccordionContent>
</AccordionItem>
);
}

return (
<AccordionItem
value={path + "." + index + "." + key}
<div
className={cn(
"border border-card rounded-lg overflow-hidden",
isEsqueryMatchedNode && "border-primary border-4",
)}
>
<AccordionTrigger className="text-sm bg-card px-4 py-3 capitalize">
{isArray && `${Math.max(index, 0)}.`} {key}
</AccordionTrigger>
<AccordionContent className="p-4 border-t">
<h3 className="text-sm bg-card px-4 py-3 capitalize">{key}</h3>
<div className="p-4 border-t">
<div className="space-y-1">
{properties.map((item, index) => (
<TreeEntry
Expand All @@ -68,7 +93,7 @@ export const ScopeItem: FC<ScopeItemProperties> = ({
/>
))}
</div>
</AccordionContent>
</AccordionItem>
</div>
</div>
);
};