feat: add html-eslint/parser explorer#99
Merged
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yeonjuan
commented
May 11, 2025
| }, | ||
| }, | ||
| optimizeDeps: { | ||
| include: ["@html-eslint/eslint-plugin"], |
Member
Author
There was a problem hiding this comment.
html-eslint is written in commonjs. (https://vite.dev/config/dep-optimization-options)
1 task
lumirlumir
added
the
accepted
lumirlumir
requested changes
May 12, 2025
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
Thanks for doing this great work👍
I’ve left a few comments about some missing parts.
| <Accordion | ||
| type="multiple" | ||
| className="px-8 pb-4 font-mono space-y-3 min-w-max" | ||
| defaultValue={["0-StyleSheet"]} |
Member
There was a problem hiding this comment.
Suggested change
| defaultValue={["0-StyleSheet"]} | |
| defaultValue={["0-Program"]} |
Oops!
Comment on lines
6
to
+9
| import { CssAst } from "./css-ast"; | ||
| import { MarkdownAst } from "./markdown-ast"; | ||
| import type { FC } from "react"; | ||
| import { HtmlAst } from "./html-ast"; |
Member
There was a problem hiding this comment.
Suggested change
| import { CssAst } from "./css-ast"; | |
| import { MarkdownAst } from "./markdown-ast"; | |
| import type { FC } from "react"; | |
| import { HtmlAst } from "./html-ast"; | |
| import { CssAst } from "./css-ast"; | |
| import { MarkdownAst } from "./markdown-ast"; | |
| import { HtmlAst } from "./html-ast"; | |
| import type { FC } from "react"; |
This is a minor stylistic suggestion. grouping the ***Ast modules together would improve clarity.
nzakas
reviewed
May 12, 2025
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
nzakas
approved these changes
May 13, 2025
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Would like @lumirlumir to review before merging.
Member
|
@lumirlumir when you're the last one to review and no one has requested other reviews, you can go ahead and merge PRs. 😄 |
Member
|
@nzakas Thank you! I've merged it. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?
I downloaded the logo image from "https://www.w3.org/html/logo/".