test: cover @page margin properties - #524
Conversation
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe test suite adds a valid Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This adds regression coverage for valid Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
DMartens
left a comment
There was a problem hiding this comment.
Changes still LGTM, thanks.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Prevent regressions where valid page-margin declarations are reported as unknown
@pagedescriptors.What changes did you make? (Give an overview)
Added a
no-invalid-at-rulestest coveringmargin,margin-top,margin-right,margin-bottom, andmargin-leftinside@page.Related Issues
Closes #519
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit
@pagerules with page size and margin declarations are accepted.