Skip to content

chore: fix section heading in no-duplicate-imports - #559

Merged
Pixel998 merged 1 commit into
eslint:mainfrom
electrohyun:chore/no-duplicate-imports-section-heading
Sep 5, 2026
Merged

chore: fix section heading in no-duplicate-imports#559
Pixel998 merged 1 commit into
eslint:mainfrom
electrohyun:chore/no-duplicate-imports-section-heading

Conversation

@electrohyun

@electrohyun electrohyun commented Sep 5, 2026

Copy link
Copy Markdown
Contributor
image

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This is a very small cleanup to keep rule section headings consistent.

What changes did you make? (Give an overview)

Renamed Rule to Rule Definition in no-duplicate-imports to match the other rules.

Related Issues

No issue

Is there anything you'd like reviewers to focus on?

No


Disclosure: I'm a participant of open source contribution program OSSCA

Summary by CodeRabbit

  • Documentation
    • Clarified the section comment describing the rule definition.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Sep 5, 2026
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: daaada64-c7a2-4f0f-af00-1b6dbb2c04dd

📥 Commits

Reviewing files that changed from the base of the PR and between 33e7314 and 94745f9.

📒 Files selected for processing (1)
  • src/rules/no-duplicate-imports.js

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The pull request renames a section comment in the duplicate-import rule. No functional behavior changes.

Changes

Rule comment update

Layer / File(s) Summary
Rename rule section comment
src/rules/no-duplicate-imports.js
The comment changes from Rule to Rule Definition.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 94745

This change updates a rule section heading for consistency and does not alter runtime behavior. It is ready to merge.

Suggested reviewers: tanujkanti4441

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the section-heading correction in no-duplicate-imports, which is the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Pixel998 Pixel998 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Pixel998
Pixel998 merged commit 8eb4c59 into eslint:main Sep 5, 2026
39 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants