Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add jsr and experimental to Deno command #71

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 26, 2025

Prerequisites checklist

What is the purpose of this pull request?

It corrects the non-working Deno installation instruction in the README > Installation section.

What changes did you make? (Give an overview)

Installation instruction corrected to read as follows:

deno add jsr:@eslint/css

Deno is marked as experimental.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Improvements or additions to documentation label Feb 26, 2025
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 26, 2025 08:05
@MikeMcC399 MikeMcC399 mentioned this pull request Feb 26, 2025
1 task
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit d9808ff into eslint:main Feb 26, 2025
22 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/deno-install-command branch February 26, 2025 18:28
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Feb 26, 2025

CI reported one error when merging this PR

https://github.com/eslint/css/actions/runs/13550339858/job/37872191467 in Verify JSR Publish

It looks like [email protected] does not like the css-tree

> @eslint/[email protected] test:jsr
> npx jsr@latest publish --dry-run

npm warn exec The following package was not found and will be installed: [email protected]
Downloading JSR release binary...
Download completed
Checking for slow types in the public API...
error[unsupported-ambient-module]: found an ambient module, which is a global augmentation, which are not unsupported
 --> /home/runner/work/css/css/typings/css-tree/index.d.ts:1:16
  | 
1 | declare module "css-tree" {
  |                ^^^^^^^^^^
  = hint: remove the ambient module declaration

I won't submit an issue for this, as it should be resolved by the updates you have already planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Deno install error: @eslint/css is missing a prefix
2 participants