Skip to content

Conversation

@SwetaTanwar
Copy link

@SwetaTanwar SwetaTanwar commented Dec 21, 2025

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Related Issues

Fix #84

Is there anything you'd like reviewers to focus on?

added tests in css repo as well - eslint/css#349

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Dec 21, 2025
@eslintbot eslintbot added this to Triage Dec 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 21, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20413711482

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 98.557%

Totals Coverage Status
Change from base Build 20089849670: 0.006%
Covered Lines: 11968
Relevant Lines: 12109

💛 - Coveralls

Copy link

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving it open for 2nd review

@snitin315 snitin315 moved this from Needs Triage to Implementing in Triage Dec 27, 2025
@snitin315 snitin315 moved this from Implementing to Second Review Needed in Triage Dec 27, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. Can you add a test with a comma in the selector?

main {
  p:first-of-type, span {
    margin-top: 0;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working

Projects

Status: Second Review Needed

Development

Successfully merging this pull request may close these issues.

Nested element selector doesn't parse correctly

4 participants