Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to eslint v9, eslint-config-eslint v11 #217

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor: switch to eslint v9, eslint-config-eslint v11 #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ module.exports = [
{
rules: {
camelcase: ["error", { properties: "never" }],

// Remove after https://github.com/eslint/eslint/pull/17900 is included in new release
"jsdoc/no-multi-asterisks": ["error", { allowWhitespace: true }]
Comment on lines -14 to -16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how this rule is now configured in eslint-config-eslint, so no need to override.

https://github.com/eslint/eslint/blob/362099c580992b2602316fc417ce3e595b96f28c/packages/eslint-config-eslint/base.js#L224

}
},
{
Expand All @@ -30,15 +27,7 @@ module.exports = [
}
},
rules: {
"n/no-unpublished-require": "off",
"n/no-extraneous-require": [
"error",
{
allowModules: [
"@octokit/rest"
]
}
]
Comment on lines -34 to -41
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using @octokit/rest in tests anymore, so there's no need to override the config for this rule.

"n/no-unpublished-require": "off"
}
}
];
Loading
Loading