fix: update the rule-tester import in rule test template#202
Merged
Conversation
The committers listed above are authorized under a signed CLA. |
Member
|
can you sign the cla, please? |
Contributor
Author
|
@aladdin-add Sure, just signed the CLA! |
aladdin-add
approved these changes
Jul 1, 2025
aladdin-add
left a comment
aladdin-add
left a comment
Member
There was a problem hiding this comment.
LGTM. Would like another review before merging.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use this generator today for implementing a new rule in ESLint core, and ran across a bug where the import in the generator rule test file could not be resolved.
I realized the correct import is
unlike what was generated (like the following)
In this PR, I have corrected the import so it reflects the latest tree structure of
eslint/eslintand updated the corresponding tests to expect the new import.I also tried to generate a new rule using my local version of
generator-eslintand it seems to work well for me.Note: I did not file an issue because the guidelines suggest that bug fixes do not require one.