chore: move CLI test tools to root level and update package.json files
#650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Apr 26, 2025
| @@ -29,12 +29,9 @@ | |||
| "@types/estree": "^0.0.51", | |||
| "@types/estree-jsx": "^0.0.1", | |||
| "@typescript-eslint/parser": "^8.7.0", | |||
| "c8": "^7.11.0", | |||
| "chai": "^4.3.6", | |||
There was a problem hiding this comment.
chai was not used in eslint-visitor-keys.
lumirlumir
commented
Apr 26, 2025
| @@ -70,6 +72,6 @@ | |||
| "release:publish": "eslint-publish-release", | |||
| "test": "npm-run-all -s test:*", | |||
| "test:cjs": "mocha --color --reporter progress --timeout 30000 tests/lib/commonjs.cjs", | |||
| "test:esm": "c8 mocha --color --reporter progress --timeout 30000 'tests/lib/**/*.js'" | |||
There was a problem hiding this comment.
In the latest version of mocha, the ' symbol was mistakenly recognized as a path, so I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
This PR moves CLI test tools (e.g., Mocha, c8) to the root
package.jsonasdevDependenciesto streamline dependency management across the monorepo.Also updated relevant
package.jsonfiles in individual packages to remove redundant entries and ensure consistent setup.Benefits of this change in a monorepo structure:
Simplified management: Reduces duplication of dependencies across packages and makes upgrades easier.
Consistency: Ensures all packages use the same versions of test tools, preventing version mismatch issues.
Faster installs: Smaller and cleaner
node_modulesin individual packages lead to faster dependency installation times.Better CI performance: Centralized tooling simplifies build and test processes in CI environments.
What changes did you make? (Give an overview)
mochaandc8to the root-levelpackage.jsonas devDependencies.mochaandc8to the latest versions, as there were no breaking issues.repositoryfield inpackage.jsonto accurately reflect the monorepo structure.keywordsfield topackage.jsonfor better discoverability.Related Issues
Is there anything you'd like reviewers to focus on?