Skip to content

chore: move CLI test tools to root level and update package.json files #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Hello,

This PR moves CLI test tools (e.g., Mocha, c8) to the root package.json as devDependencies to streamline dependency management across the monorepo.

Also updated relevant package.json files in individual packages to remove redundant entries and ensure consistent setup.

Benefits of this change in a monorepo structure:

  • Simplified management: Reduces duplication of dependencies across packages and makes upgrades easier.

  • Consistency: Ensures all packages use the same versions of test tools, preventing version mismatch issues.

  • Faster installs: Smaller and cleaner node_modules in individual packages lead to faster dependency installation times.

  • Better CI performance: Centralized tooling simplifies build and test processes in CI environments.

What changes did you make? (Give an overview)

  1. Moved mocha and c8 to the root-level package.json as devDependencies.
  2. Upgraded mocha and c8 to the latest versions, as there were no breaking issues.
  3. Updated the repository field in package.json to accurately reflect the monorepo structure.
  4. Added a keywords field to package.json for better discoverability.

Related Issues

Is there anything you'd like reviewers to focus on?

@@ -29,12 +29,9 @@
"@types/estree": "^0.0.51",
"@types/estree-jsx": "^0.0.1",
"@typescript-eslint/parser": "^8.7.0",
"c8": "^7.11.0",
"chai": "^4.3.6",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chai was not used in eslint-visitor-keys.

@@ -70,6 +72,6 @@
"release:publish": "eslint-publish-release",
"test": "npm-run-all -s test:*",
"test:cjs": "mocha --color --reporter progress --timeout 30000 tests/lib/commonjs.cjs",
"test:esm": "c8 mocha --color --reporter progress --timeout 30000 'tests/lib/**/*.js'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest version of mocha, the ' symbol was mistakenly recognized as a path, so I removed it.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 308e239 into eslint:main Apr 28, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Apr 28, 2025
@lumirlumir lumirlumir deleted the chore-move-cli-test-tools-to-root-level-and-update-package-json-files branch April 28, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants