Skip to content

fix: improve no-html rule's tag location reporting #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nzakas merged 6 commits into from
Aug 22, 2025
Merged

fix: improve no-html rule's tag location reporting #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebbb607
fix: improve no-html rule's tag location reporting
TKDev7 Jul 31, 2025
669dd45
use regex pattern instead of indexOf
TKDev7 Aug 5, 2025
5dea7a4
correctly handle > in HTML attribute values
TKDev7 Aug 6, 2025
c88961d
add test
TKDev7 Aug 9, 2025
843a4b3
simplify regex for detecting line endings
TKDev7 Aug 16, 2025
3c472a4
Merge branch 'main' into no-html-location-reporting
TKDev7 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/rules/no-html.js
View file
Open in desktop
Comment thread
TKDev7 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ import { findOffsets } from "../util.js";
// Helpers
//-----------------------------------------------------------------------------

const htmlTagPattern = /<([a-z0-9]+(?:-[a-z0-9]+)*)/giu;
const htmlTagPattern =
Comment thread
lumirlumir marked this conversation as resolved.
/<([a-z0-9]+(?:-[a-z0-9]+)*)(?:\s+(?:[^>"']|"[^"]*"|'[^']*')*)?>/giu;
const lineEndingPattern = /\r\n?|\n/u;

//-----------------------------------------------------------------------------
// Rule Definition
Expand Down Expand Up @@ -82,6 +84,7 @@ export default {
let match;

while ((match = htmlTagPattern.exec(node.value)) !== null) {
const fullMatch = match[0];
const tagName = match[1];
const { lineOffset, columnOffset } = findOffsets(
node.value,
Expand All @@ -91,9 +94,17 @@ export default {
line: node.position.start.line + lineOffset,
column: node.position.start.column + columnOffset,
};

const firstNewlineIndex =
fullMatch.search(lineEndingPattern);
const endColumn =
firstNewlineIndex === -1
? start.column + fullMatch.length
: start.column + firstNewlineIndex;

const end = {
line: start.line,
column: start.column + match[0].length + 1,
column: endColumn,
};

const tagToCheck = allowedIgnoreCase
Expand Down
202 changes: 202 additions & 0 deletions tests/rules/no-html.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,5 +222,207 @@ ruleTester.run("no-html", rule, {
},
],
},
{
code: "<span >Content</span>",
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 8,
data: { name: "span" },
},
],
},
{
code: '<div id="foo">Some content</div>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 15,
data: {
name: "div",
},
},
],
},
{
code: '<p class="text-center" data-attr="value">Content</p>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 42,
data: {
name: "p",
},
},
],
},
{
code: '<span\nclass="highlight"\ndata-id="123">Text</span>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 6,
data: {
name: "span",
},
},
],
},
{
code: '<span\rclass="highlight"\rdata-id="123">Text</span>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 6,
data: {
name: "span",
},
},
],
},
{
code: '<span\r\nclass="highlight"\r\ndata-id="123">Text</span>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 6,
data: {
name: "span",
},
},
],
},
{
code: '<div class="test" >Content</div>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 24,
data: { name: "div" },
},
],
},
{
code: '<input type="text" placeholder="Enter text" />',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 47,
data: {
name: "input",
},
},
],
},
{
code: '<a href="#"><span class="highlight">Link</span></a>',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 13,
data: { name: "a" },
},
{
messageId: "disallowedElement",
line: 1,
column: 13,
endLine: 1,
endColumn: 37,
data: { name: "span" },
},
],
},
{
code: '<input placeholder=">" />',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 26,
data: {
name: "input",
},
},
],
},
{
code: "<input placeholder='>'></input>",
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 24,
data: {
name: "input",
},
},
],
},
{
code: '<input\nplaceholder=">" />',
errors: [
{
messageId: "disallowedElement",
line: 1,
column: 1,
endLine: 1,
endColumn: 7,
data: {
name: "input",
},
},
],
},
Comment thread
snitin315 marked this conversation as resolved.
{
code: dedent`
<!-- comment -->
<input
placeholder="Enter name"
name="First Name"
/>`,
errors: [
{
messageId: "disallowedElement",
line: 2,
column: 1,
endLine: 2,
endColumn: 7,
data: {
name: "input",
},
},
],
},
],
});
Loading