Skip to content

Conversation

@lumirlumir
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've centralized the ci-package-manager workflow as part of the effort to centralize workflows (ref: eslint/workflows#4).

I renamed the workflow file from ci-build-all-pm to ci-package-manager to make its purpose clearer.

For detailed context, please refer to eslint/workflows#25.

What changes did you make? (Give an overview)

In this PR, I centralized the ci-package-manager workflow.

Related Issues

Refs: eslint/workflows#25, eslint/workflows#4

Is there anything you'd like reviewers to focus on?

N/A

@eslintbot eslintbot added this to Triage Dec 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 7, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Dec 7, 2025
@lumirlumir lumirlumir moved this from Implementing to Needs Triage in Triage Dec 10, 2025
@lumirlumir lumirlumir marked this pull request as ready for review December 10, 2025 04:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the package manager CI workflow as part of the broader ESLint organization effort to consolidate reusable workflows into the eslint/workflows repository. The previous local implementation (ci-build-all-pm.yml) contained 131 lines of workflow definition that tested package installation across npm, Yarn v1, Yarn Modern, pnpm, and bun. This has been replaced with a 14-line wrapper that references the centralized workflow.

Key Changes:

  • Replaced local ci-build-all-pm.yml workflow (131 lines) with centralized reference in ci-package-manager.yml (14 lines)
  • Added *.tgz to .gitignore to exclude npm pack outputs from version control

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
.gitignore Added *.tgz pattern to ignore tarball files generated by npm pack during workflow execution
.github/workflows/ci-package-manager.yml New workflow file that references the centralized ci-package-manager workflow from eslint/workflows repository
.github/workflows/ci-build-all-pm.yml Removed local workflow implementation (now centralized)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aladdin-add aladdin-add merged commit 28f0df4 into main Dec 10, 2025
30 checks passed
@aladdin-add aladdin-add deleted the ci-centralize-package-manager branch December 10, 2025 06:40
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants