ci: run arethetypeswrong in CI
#598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Dec 9, 2025
| "scripts": { | ||
| "lint": "eslint && eslint -c eslint.config-content.js", | ||
| "lint:fix": "eslint --fix && eslint --fix -c eslint.config-content.js", | ||
| "lint:types": "attw --pack --profile esm-only", |
Member
Author
There was a problem hiding this comment.
Currently, the @eslint/markdown package is ESM-only, so I added the --profile esm-only option.
There was a problem hiding this comment.
Pull request overview
This PR adds the arethetypeswrong package validation tool to CI workflows, following the pattern established in the main ESLint repository. The implementation adds automated type definition checking to catch potential issues with package exports and TypeScript types before publishing.
- Added
@arethetypeswrong/clias a dev dependency with thelint:typesnpm script - Created a new
are-the-types-wrongCI job to validate package type definitions - Removed redundant
npm run buildcommands from CI workflows since build runs automatically via thepreparescript duringnpm install
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added @arethetypeswrong/cli dependency and lint:types script for type validation |
| .github/workflows/ci.yml | Added new are-the-types-wrong job and removed redundant build steps from test_types and jsr_test jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR is a follow-up to eslint/rewrite#338.
I've added the
arethetypeswrongcheck to CI to validate package types, usingeslintandeslint-config-eslintfrom the main repo as examples (https://github.com/eslint/eslint/blob/v10.0.0-alpha.1/.github/workflows/types-integration.yml#L181-L210).I also removed a redundant
npm run buildafternpm installfrom the workflows, since it already runs duringprepare.markdown/package.json
Line 70 in a2ccff8
What changes did you make? (Give an overview)
In this PR, I've added the
arethetypeswrongcheck to CI to validate package types.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A