feat: Add separate MCP server package #201
Open
+685
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The failure is a Mocha timeout. Seems intermittent. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new @eslint/mcp package that implements an MCP server for ESLint along with its CLI and accompanying tests and configuration updates.
- Port the existing mcp-server.js into the new package with a corresponding CLI executable.
- Add tests for both the MCP server and CLI, as well as update documentation, workflows, and issue templates to support the new package.
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/mcp/tests/mcp-server.test.js | Added tests for MCP server tools functionality |
| packages/mcp/tests/mcp-cli.js | Added CLI tests to verify startup behavior |
| packages/mcp/tests/fixtures/* | Added fixture files for testing linting outcomes |
| packages/mcp/src/mcp-server.js | Implemented the MCP server using ESLint integration |
| packages/mcp/src/mcp-cli.js | Provided a CLI to initialize and run the MCP server |
| packages/mcp/README.md | Updated documentation to include usage for the new package |
| Other configuration files (.github/workflows, etc.) | Updated CI/workflows and issue templates to include the MCP package |
Files not reviewed (4)
- .release-please-manifest.json: Language not supported
- packages/mcp/package.json: Language not supported
- packages/mcp/tsconfig.json: Language not supported
- release-please-config.json: Language not supported
fasttime
reviewed
May 7, 2025
mdjermanovic
reviewed
May 7, 2025
mdjermanovic
reviewed
May 7, 2025
| if: ${{ inputs.package != 'migrate-config' }} | ||
| run: npx jsr publish | ||
| run: | | ||
| if [ -f "packages/${{ inputs.package }}/jsr.json" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ -f "packages/${{ inputs.package }}/jsr.json" ]; then | |
| if [ -f "jsr.json" ]; then |
As this runs in the directory of the package (working-directory: packages/${{ inputs.package }}).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds a new
@eslint/mcppackage.What changes did you make? (Give an overview)
mcp-server.jsfrom theeslintrepo, along with tests.Related Issues
refs eslint/eslint#19682
Is there anything you'd like reviewers to focus on?
This package has no JSR equivalent because it's a binary.
Also, because it's a binary, I'm not rolling up or converting to CommonJS. It stays ESM and the
srcdirectory is published.These were simplifying decisions based on the uniqueness of this package. I think this is okay because there is no API exposed through the package.