Skip to content

ci: declare workflow-level contents: read on 4 workflows#452

Merged
lumirlumir merged 1 commit into
eslint:mainfrom
arpitjain099:chore/declare-workflow-perms-readonly
May 19, 2026
Merged

ci: declare workflow-level contents: read on 4 workflows#452
lumirlumir merged 1 commit into
eslint:mainfrom
arpitjain099:chore/declare-workflow-perms-readonly

Conversation

@arpitjain099
Copy link
Copy Markdown
Contributor

Pins the default GITHUB_TOKEN to contents: read on 4 workflows in .github/workflows/ that don't call a GitHub API beyond the initial checkout.

Why

CVE-2025-30066 (March 2025 tj-actions/changed-files supply-chain compromise) exfiltrated GITHUB_TOKEN from workflow logs. Pinning per workflow caps runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load on each touched file.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 15, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage May 18, 2026
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed the CI check. The changes look good to me, but could you take a look at the formatting failure? The "Are the types wrong" CI failure should be resolved once the branch is rebased.

@arpitjain099
Copy link
Copy Markdown
Contributor Author

Thanks @lumirlumir, good catch. Two fixes pushed:

  1. Re-indented the permissions: block from 2 to 4 spaces to match the rest of the workflow YAML (that was the Verify Files failure).
  2. Rebased on main so the "Are the types wrong" check resolves.

Let me know if you spot anything else.

Pins the default GITHUB_TOKEN to contents: read on the workflows in
.github/workflows/ that don't call a GitHub API beyond the initial
checkout. The other workflows in this directory are left implicit
because they need write scopes that a maintainer is better placed
to declare.

Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files
compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow
caps bound runtime authority irrespective of repo or org default,
give drift protection if the default ever widens, and are credited
per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@arpitjain099 arpitjain099 force-pushed the chore/declare-workflow-perms-readonly branch from 7452473 to 2116172 Compare May 19, 2026 12:07
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit 887ee83 into eslint:main May 19, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants