Skip to content

chore: pin fflate@0.8.2#458

Merged
fasttime merged 1 commit into
mainfrom
pin-fflate
May 16, 2026
Merged

chore: pin fflate@0.8.2#458
fasttime merged 1 commit into
mainfrom
pin-fflate

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Similar to eslint/eslint#20877.

Fixes CI failure when running lint:types scripts:

https://github.com/eslint/rewrite/actions/runs/25950047972/job/76286009745

Run npm run lint:types

> eslint-rewrite@1.0.0 lint:types
> npm run lint:types --workspaces --if-present


> @eslint/compat@2.1.0 lint:types
> attw --pack

error while checking file:
Cannot read properties of undefined (reading 'filename')
npm error Lifecycle script `lint:types` failed with error:
npm error code 3
npm error path /home/runner/work/rewrite/rewrite/packages/compat
npm error workspace @eslint/compat@2.1.0
npm error location /home/runner/work/rewrite/rewrite/packages/compat
npm error command failed
npm error command sh -c attw --pack

...
(same for all other packages)

What changes did you make? (Give an overview)

Per arethetypeswrong/arethetypeswrong.github.io#258, the problem is caused by @arethetypeswrong/core relying on an internal behavior of fflate, which has changed in recently released v0.8.3.

As this might not be fixed soon, this PR adds overrides to pin fflate to v0.8.2 for @arethetypeswrong/core.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 16, 2026
@fasttime fasttime moved this from Needs Triage to Implementing in Triage May 16, 2026
Copy link
Copy Markdown
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 12b76ca into main May 16, 2026
35 checks passed
@fasttime fasttime deleted the pin-fflate branch May 16, 2026 18:28
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants