Skip to content

fix: copy and update discord-transcript-generator to update discord.js#646

Merged
nzakas merged 4 commits into
eslint:mainfrom
DMartens:internalize-discord-transcript-generator
May 13, 2026
Merged

fix: copy and update discord-transcript-generator to update discord.js#646
nzakas merged 4 commits into
eslint:mainfrom
DMartens:internalize-discord-transcript-generator

Conversation

@DMartens

@DMartens DMartens commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Fix the transcription of discord messages for TSC meetings.
The issue is likely that the we used the old API version as the migration guide mentions that discord.js v14 uses the new API version.

What changes did you make? (Give an overview)

  • Copy discord-transcript-generator as it seems unmaintained
  • Add dependency on discord.js v14 (discord-transcript-generator used v12)
  • Three changes because of the new discord.js version
    • pass intents in the Client constructor call
    • use clientReady event instead of ready
    • use Array.from instead of DiscordJSCollection#array() to convert to an array

Related Issues

Fixes #644

Is there anything you'd like reviewers to focus on?

Should the new file be moved somewhere else?
Should I modify the file further (e.g. fix linter errors)?

@nzakas

nzakas commented Dec 29, 2025

Copy link
Copy Markdown
Member

This looks great, thanks!

Yes, I think we should enable ESLint and fix linting errors.

@nzakas

nzakas commented Dec 30, 2025

Copy link
Copy Markdown
Member

@DMartens can you check the merge conflicts?

@DMartens DMartens force-pushed the internalize-discord-transcript-generator branch 2 times, most recently from 8476b1b to 31c8072 Compare December 31, 2025 10:25

@aladdin-add aladdin-add left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas

nzakas commented Jan 14, 2026

Copy link
Copy Markdown
Member

Sorry, one more merge conflict.

@DMartens DMartens force-pushed the internalize-discord-transcript-generator branch from fd052fa to be88e2a Compare January 19, 2026 20:17
@DMartens

Copy link
Copy Markdown
Contributor Author

Sorry this fell through the cracks. I rebased on main and reran npm install to refresh the package-lock.json.

@nzakas

nzakas commented Jan 20, 2026

Copy link
Copy Markdown
Member

It doesn't appear that worked as it's still saying there's a conflict. Can you double check?

@DMartens DMartens force-pushed the internalize-discord-transcript-generator branch from be88e2a to f54edcb Compare January 21, 2026 14:46
@DMartens

DMartens commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

The problem was that #667 was merged in the meantime but maybe we should not merge this PR and just keep it open as it started working again.

@nzakas

nzakas commented Jan 30, 2026

Copy link
Copy Markdown
Member

We can do that. Maybe it was a bug in their API.

It still seems like we can't get a transcript for November 13. Can you see if this approach can generate that?

@DMartens

Copy link
Copy Markdown
Contributor Author

I do not think I can as I do not have the API keys (I checked whether it works by creating a discord channel and adding the bot).
Is there a way for Github actions to use the code of a PR?

@nzakas

nzakas commented Feb 3, 2026

Copy link
Copy Markdown
Member

Not that I'm aware of. That's okay, I don't think it's worth the time to look into getting this one missing transcript if it's not easy.

@nzakas nzakas closed this Feb 3, 2026
@nzakas

nzakas commented May 5, 2026

Copy link
Copy Markdown
Member

Reopening because the latest transcript is missing again. We should probably finish up work on this and switch to it.

@nzakas nzakas reopened this May 5, 2026
@DMartens DMartens force-pushed the internalize-discord-transcript-generator branch from f54edcb to febf2a4 Compare May 7, 2026 21:42
@DMartens

DMartens commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on main, so this PR should be ready (we did not merge because the transcript generator started working again and we had no easy way to check whether this will work in an action).

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try.

@nzakas nzakas merged commit f36c75b into eslint:main May 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Discord transcript generator

3 participants