fix: copy and update discord-transcript-generator to update discord.js#646
Conversation
|
This looks great, thanks! Yes, I think we should enable ESLint and fix linting errors. |
|
@DMartens can you check the merge conflicts? |
8476b1b to
31c8072
Compare
|
Sorry, one more merge conflict. |
fd052fa to
be88e2a
Compare
|
Sorry this fell through the cracks. I rebased on main and reran |
|
It doesn't appear that worked as it's still saying there's a conflict. Can you double check? |
be88e2a to
f54edcb
Compare
|
The problem was that #667 was merged in the meantime but maybe we should not merge this PR and just keep it open as it started working again. |
|
We can do that. Maybe it was a bug in their API. It still seems like we can't get a transcript for November 13. Can you see if this approach can generate that? |
|
I do not think I can as I do not have the API keys (I checked whether it works by creating a discord channel and adding the bot). |
|
Not that I'm aware of. That's okay, I don't think it's worth the time to look into getting this one missing transcript if it's not easy. |
|
Reopening because the latest transcript is missing again. We should probably finish up work on this and switch to it. |
f54edcb to
febf2a4
Compare
|
Rebased on main, so this PR should be ready (we did not merge because the transcript generator started working again and we had no easy way to check whether this will work in an action). |
Prerequisites checklist
What is the purpose of this pull request?
Fix the transcription of discord messages for TSC meetings.
The issue is likely that the we used the old API version as the migration guide mentions that
discord.jsv14 uses the new API version.What changes did you make? (Give an overview)
discord-transcript-generatoras it seems unmaintaineddiscord.jsv14 (discord-transcript-generatorused v12)discord.jsversionintentsin theClientconstructor callclientReadyevent instead ofreadyArray.frominstead ofDiscordJSCollection#array()to convert to an arrayRelated Issues
Fixes #644
Is there anything you'd like reviewers to focus on?
Should the new file be moved somewhere else?
Should I modify the file further (e.g. fix linter errors)?