Prevent path traversal in module resolution#1353
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens server-side module resolution to prevent path traversal by validating that resolved module file paths remain within the build working directory (ctx.wd), reducing the risk of resolving/reading files outside the intended package workspace.
Changes:
- Add a working-directory boundary check after computing a module’s resolved filename under
node_modules/<pkgName>/.... - Fail resolution with a generic error when the computed path escapes the working directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| filename = path.Join(ctx.wd, "node_modules", ctx.esmPath.PkgName, modulePath) | ||
| // check if the filename is within the working directory | ||
| if !strings.HasPrefix(filename, ctx.wd+string(os.PathSeparator)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.